kevinrr888 commented on code in PR #5576:
URL: https://github.com/apache/accumulo/pull/5576#discussion_r2109880594


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java:
##########
@@ -475,7 +475,10 @@ public synchronized void open(String address) throws 
IOException {
       throw new IOException(ex);
     }
 
-    syncThread = Threads.createThread("Accumulo WALog thread " + this, new 
LogSyncingTask());
+    // TODO KEVIN RATHBUN this seems like a vital thread for TabletServer, but 
appears that the
+    // thread will continuously be recreated, so probably fine to stay non 
critical
+    syncThread =
+        Threads.createNonCriticalThread("Accumulo WALog thread " + this, new 
LogSyncingTask());

Review Comment:
   Addressed in 2c4ce6bc57b166a2a57eb61c11df5b2bb8da76b8



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to