kevinrr888 commented on code in PR #5547:
URL: https://github.com/apache/accumulo/pull/5547#discussion_r2124733801
##########
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterImpl.java:
##########
@@ -260,12 +261,12 @@ public MiniAccumuloClusterImpl(MiniAccumuloConfigImpl
config) throws IOException
clientProps.put(ClientProperty.AUTH_TOKEN.getKey(),
config.getRootPassword());
}
- File clientPropsFile = config.getClientPropsFile();
+ java.nio.file.Path clientPropsFile = config.getClientPropsFile().toPath();
writeConfigProperties(clientPropsFile, clientProps);
- File siteFile = confDir.resolve("accumulo.properties").toFile();
+ java.nio.file.Path siteFile = confDir.resolve("accumulo.properties");
writeConfigProperties(siteFile, config.getSiteConfig());
- this.siteConfig = SiteConfiguration.fromFile(siteFile).build();
+ this.siteConfig = SiteConfiguration.fromFile(siteFile.toFile()).build();
Review Comment:
Yeah, I suppose the only change would be to make `SiteConfiguration` take
Path, which we probably don't want to do here.
If we changed `writeConfigProperties` to accept a File instead, we would
still be converting between Path and File, right? You would still need
something like
`java.nio.file.Path siteFile =
confDir.resolve("accumulo.properties").toFile();`? So there would be no benefit
to doing that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
