kevinrr888 commented on code in PR #5547:
URL: https://github.com/apache/accumulo/pull/5547#discussion_r2124743205
##########
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterImpl.java:
##########
@@ -490,8 +496,9 @@ private void writeConfig(File file,
Iterable<Map.Entry<String,String>> settings)
fileWriter.close();
}
- private void writeConfigProperties(File file, Map<String,String> settings)
throws IOException {
- BufferedWriter fileWriter = Files.newBufferedWriter(file.toPath());
+ private void writeConfigProperties(java.nio.file.Path file,
Map<String,String> settings)
Review Comment:
Yeah, I don't have any problem with this, I was just wondering if some of
the conversions could be avoided, but it doesn't seem like they can:
https://github.com/apache/accumulo/pull/5547#discussion_r2116311345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
