dlmarion commented on code in PR #5613:
URL: https://github.com/apache/accumulo/pull/5613#discussion_r2130068889
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftTransportPool.java:
##########
@@ -94,17 +104,20 @@ private ThriftTransportPool(LongSupplier maxAgeMillis) {
} catch (TransportPoolShutdownException e) {
log.debug("Error closing expired connections", e);
}
- });
+ };
Review Comment:
With this change the server will terminate if this thread exits for any
reason. The AccumuloUncaughtExceptionHandler will be invoked for any uncaught
exception that causes this thread to exit. Because InterruptedException is
caught, the UEH will not be invoked, and nothing will be logged. We likely want
to add logging in the InterruptedException case. The logging in
AccumuloUncaughtExceptionHandler should be sufficient for other
RuntimeException's.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
