keith-turner commented on code in PR #5613:
URL: https://github.com/apache/accumulo/pull/5613#discussion_r2132868293
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftTransportPool.java:
##########
@@ -94,17 +104,20 @@ private ThriftTransportPool(LongSupplier maxAgeMillis) {
} catch (TransportPoolShutdownException e) {
log.debug("Error closing expired connections", e);
}
- });
+ };
Review Comment:
Would be nice to add a warn log when the interrupt exception happens, the
log message could state it was ignored. Warn makes it more likely to see the
event was ignored, in case we want to change how that exception is handled in
the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
