kevinrr888 opened a new pull request, #5632:
URL: https://github.com/apache/accumulo/pull/5632
- Explored all properties for those that should be "fixed", updating the set
of fixed properties appropriately
- Log a warning when the user sets or deletes a fixed property via the Shell
or InstanceOperations API. Message is logged in shell when using shell, and
logged server side (Manager) when using InstanceOperations.
- Updated incomplete/outdated ConfigCommand usage message
When determining what is a fixed property:
- Ignored those that have a blank or null default value, as these cannot be
fixed
- Ignored table ("table.") properties
- If the Property has any use case where the value is retrieved from the
config, used or stored, and never retrieved again, declared the property as
fixed.
- In some cases, there are multiple uses of the property, where only
one use is "fixed". For example, `TSERV_MINC_MAXCONCURRENT` as it's used in
`TabletServerResourceManager` would be considered non-fixed as the property is
checked in a periodic task. However, it is also used in
`LargestFirstMemoryManager` in the `init()` method. `init()` is invoked once in
the `TabletServerResourceManager` constructor. A `TabletServerResourceManager`
is created once per `TabletServer` and `ScanServer`. So in this case,
`TSERV_MINC_MAXCONCURRENT` is fixed. If any use is "fixed", declared the
property to be "fixed".
- "use case" meaning a real use within the related Server(s), not
something like logging
Follow ons:
- In 4.0, a follow on for this could be to replace this set with a new
constructor arg (each Property is declared as IS_FIXED or NOT_FIXED).
- In 4.0, also need to consider any new Properties in 4.0 when merging this
from 2.1->4.0
- Another follow on could be to explore making as many of these "fixed"
properties "non-fixed" as we can. I saw many places this could be done when
working on this. Not sure if this should be a 2.1 or 4.0 change. Would probably
be safest for 4.0.
closes #5562, #5563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
