kevinrr888 commented on code in PR #5632:
URL: https://github.com/apache/accumulo/pull/5632#discussion_r2140432495
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -1939,7 +1941,54 @@ public static boolean isValidTablePropertyKey(String
key) {
// others
TSERV_NATIVEMAP_ENABLED, TSERV_MAXMEM, TSERV_SCAN_MAX_OPENFILES,
- MANAGER_RECOVERY_WAL_EXISTENCE_CACHE_TIME,
COMPACTION_COORDINATOR_FINALIZER_QUEUE_SIZE);
+ MANAGER_RECOVERY_WAL_EXISTENCE_CACHE_TIME,
COMPACTION_COORDINATOR_FINALIZER_QUEUE_SIZE,
Review Comment:
Adding all the new Properties added to FIXED_PROPERTIES at the end of the
list, for easier review. Will organize these in a later commit.
##########
core/src/main/java/org/apache/accumulo/core/util/compaction/CompactionServicesConfig.java:
##########
@@ -53,6 +53,7 @@ private long getDefaultThroughput(AccumuloConfiguration
aconf) {
return aconf.getAsBytes(Property.TSERV_MAJC_THROUGHPUT);
}
+ // TODO is this supposed to be getting the default value or should it be
reading from config?
Review Comment:
Self reminder to remove this TODO or fix if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
