kevinrr888 commented on code in PR #5623:
URL: https://github.com/apache/accumulo/pull/5623#discussion_r2140720349
##########
server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tservers/TabletServers.java:
##########
@@ -23,11 +23,15 @@
import org.apache.accumulo.monitor.rest.manager.ManagerInformation;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
/**
* Generates a list of servers, bad servers, and dead servers
*
* @since 2.0.0
*/
+@SuppressFBWarnings(value = "PA_PUBLIC_PRIMITIVE_ATTRIBUTE",
+ justification = "class used for serialization")
Review Comment:
Why can't the fields here be private? Seems they are only used in this class
anyways
##########
pom.xml:
##########
@@ -731,13 +731,14 @@
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
- <version>4.7.3.6</version>
+ <version>4.9.3.0</version>
<configuration>
<xmlOutput>true</xmlOutput>
<effort>Max</effort>
<failOnError>true</failOnError>
<includeTests>true</includeTests>
<maxRank>16</maxRank>
+
<omitVisitors>ConstructorThrow,SharedVariableAtomicityDetector</omitVisitors>
Review Comment:
Why are these omitted?
##########
server/base/src/main/java/org/apache/accumulo/server/security/delegation/AuthenticationTokenSecretManager.java:
##########
@@ -282,6 +284,7 @@ protected SecretKey generateSecret() {
return super.generateSecret();
}
+ @SuppressFBWarnings(value = "HSM_HIDING_METHOD", justification = "")
Review Comment:
Looked into this and I don't think it can be removed. `SecretManager` is a
Hadoop class (so can't change scope) and `createSecretKey` is a protected
method within that. So, can access it in this class (extends `SecretManager`)
but not in the class that calls
`AuthenticationTokenSecretManager.createSecretKey()`
##########
server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tservers/TabletServerInformation.java:
##########
@@ -32,11 +32,15 @@
import org.apache.accumulo.monitor.rest.trace.RecoveryStatusInformation;
import org.apache.accumulo.server.util.TableInfoUtil;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
/**
* Generates tserver information
*
* @since 2.0.0
*/
+@SuppressFBWarnings(value = "PA_PUBLIC_PRIMITIVE_ATTRIBUTE",
+ justification = "public member variables only referenced from tests, class
used for serialization")
Review Comment:
Could also just add getters for each var and make them private but there are
a lot of vars here so this suppression seems fine to me as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
