dlmarion commented on code in PR #5623:
URL: https://github.com/apache/accumulo/pull/5623#discussion_r2141004933
##########
pom.xml:
##########
@@ -731,13 +731,14 @@
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
- <version>4.7.3.6</version>
+ <version>4.9.3.0</version>
<configuration>
<xmlOutput>true</xmlOutput>
<effort>Max</effort>
<failOnError>true</failOnError>
<includeTests>true</includeTests>
<maxRank>16</maxRank>
+
<omitVisitors>ConstructorThrow,SharedVariableAtomicityDetector</omitVisitors>
Review Comment:
> For SharedVariableAtomicityDetector, may need to open a follow on issue
about this.
Agreed, I was going to do that for main. Each instance likely needs to be
evaluated. Looking at https://github.com/spotbugs/spotbugs/issues/3390, we can
probably just mark our not thread-safe classes with an annotation. I'm not sure
that there is a release yet with this change in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
