kevinrr888 commented on code in PR #5659:
URL: https://github.com/apache/accumulo/pull/5659#discussion_r2155066062
##########
server/base/src/main/java/org/apache/accumulo/server/AccumuloDataVersion.java:
##########
@@ -113,7 +113,6 @@ private static String dataVersionToReleaseName(final int
version) {
case REMOVE_DEPRECATIONS_FOR_VERSION_3:
return "3.0.0";
case METADATA_FILE_JSON_ENCODING:
- return "3.1.0";
Review Comment:
The upgrade steps before 3.1 was dropped were 3.0 (11) -> 3.1 (12) -> 4.0
(13) now it's more like 3.0 (11) -> 4.0 (12) -> 4.0 (13). I'm thinking since we
no longer need to support upgrading to 3.1, we could combine the upgrade
process of 12 and 13.
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -365,16 +365,10 @@ public enum Property {
"A comma separated list of tags to emit with all metrics from the
process. Example:"
+ "\"tag1=value1,tag2=value2\".",
"4.0.0"),
- // TODO: Make sure to backport this to 3.1, then remove here in 4.0
- @Deprecated(since = "3.1.0")
- @ReplacedBy(property = RPC_PROCESS_BIND_ADDRESS)
- GENERAL_PROCESS_BIND_ADDRESS("general.process.bind.addr", "0.0.0.0",
PropertyType.STRING,
- "The local IP address to which this server should bind for sending and
receiving network traffic.",
- "3.0.0"),
Review Comment:
I think this prop can safely be deleted now as it's not present in 2.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
