keith-turner commented on code in PR #5659:
URL: https://github.com/apache/accumulo/pull/5659#discussion_r2164810791
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchWriter.java:
##########
@@ -1123,21 +1123,12 @@ private void cancelSession() throws
InterruptedException, ThriftSecurityExceptio
} else {
client = ThriftUtil.getClient(ThriftClientTypes.TABLET_INGEST,
parsedServer, context);
}
-
- if (useCloseUpdate) {
Review Comment:
May be able to remove this `useCloseUpdate` variable can be removed and the
code that interacts with it.
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -365,16 +365,10 @@ public enum Property {
"A comma separated list of tags to emit with all metrics from the
process. Example:"
+ "\"tag1=value1,tag2=value2\".",
"4.0.0"),
- // TODO: Make sure to backport this to 3.1, then remove here in 4.0
- @Deprecated(since = "3.1.0")
- @ReplacedBy(property = RPC_PROCESS_BIND_ADDRESS)
- GENERAL_PROCESS_BIND_ADDRESS("general.process.bind.addr", "0.0.0.0",
PropertyType.STRING,
- "The local IP address to which this server should bind for sending and
receiving network traffic.",
- "3.0.0"),
Review Comment:
Maybe it was present in the 3.0 release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
