keith-turner commented on code in PR #5668:
URL: https://github.com/apache/accumulo/pull/5668#discussion_r2159491085
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletManagementIterator.java:
##########
@@ -237,10 +237,17 @@ public Entry<Key,Value> next() {
Exception error = null;
try {
- LOG.trace("Evaluating extent: {}", tm);
- computeTabletManagementActions(tm, actions);
- } catch (Exception e) {
- LOG.error("Error computing tablet management actions for extent: {}",
tm.getExtent(), e);
+ // Validate that a minimum set of keys were seen to create a valid tablet
+ tm.getPrevEndRow();
Review Comment:
A few lines up there is a call to TabletMetadata.convertRow() that could
possibly fail. If it does it would be nice to handle that propogating back an
error and log `keys.get(0).getRow()` to point to the row of the busted tablet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
