dlmarion commented on code in PR #5668:
URL: https://github.com/apache/accumulo/pull/5668#discussion_r2183607709
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -488,9 +488,17 @@ private TableMgmtStats
manageTablets(Iterator<TabletManagement> iter,
if (mtiError != null) {
// An error happened on the TabletServer in the
TabletManagementIterator
// when trying to process this extent.
+ KeyExtent ke = null;
+ try {
+ ke = tm.getExtent();
+ } catch (IllegalStateException e) {
+ // thrown when no prev endrow in tablet metadata.
+ // suppress this exception and leave ke set to null
Review Comment:
Do you think logging this will add confusion in the log. There is a log
message two lines down with the error from the server side.
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -488,9 +488,17 @@ private TableMgmtStats
manageTablets(Iterator<TabletManagement> iter,
if (mtiError != null) {
// An error happened on the TabletServer in the
TabletManagementIterator
// when trying to process this extent.
+ KeyExtent ke = null;
+ try {
+ ke = tm.getExtent();
+ } catch (IllegalStateException e) {
+ // thrown when no prev endrow in tablet metadata.
+ // suppress this exception and leave ke set to null
+ }
+ String errorLocation = ke == null ? " table: " + tm.getTableId() : "
extent: " + ke;
Review Comment:
In TabletManagementIterator.filter, if there are actions or an error, then
the keys for the tablet metadata are returned. Before returning the keys, it
inserts an action or error key into the set of keys. I don't think tm will be
null here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
