kevinrr888 commented on code in PR #5670:
URL: https://github.com/apache/accumulo/pull/5670#discussion_r2159650260
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java:
##########
@@ -834,6 +834,17 @@ public ConditionalWriter createConditionalWriter(String
tableName) throws TableN
return createConditionalWriter(tableName, null);
}
+ public ConditionalWriter createConditionalWriterForFateTable(String
tableName)
+ throws TableNotFoundException {
+ ConditionalWriterImpl writer = (ConditionalWriterImpl)
createConditionalWriter(tableName);
+ Integer maxThreads =
+
ClientProperty.CONDITIONAL_WRITER_THREADS_MAX_FATE_TABLE.getInteger(getClientProperties());
+ if (maxThreads != null) {
+ writer.getConfig().setMaxWriteThreads(maxThreads);
+ }
+ return writer;
+ }
+
Review Comment:
we don't want this in public API, so not putting this declaration in
AccumuloClient
##########
core/src/main/java/org/apache/accumulo/core/conf/ClientProperty.java:
##########
@@ -81,6 +81,10 @@ public enum ClientProperty {
"2.1.0", false),
CONDITIONAL_WRITER_THREADS_MAX("conditional.writer.threads.max", "3",
PropertyType.COUNT,
"Maximum number of threads to use for writing data to tablet servers.",
"2.1.0", false),
+
CONDITIONAL_WRITER_THREADS_MAX_FATE_TABLE("conditional.writer.threads.max.fate.table",
"3",
+ PropertyType.COUNT,
+ "Maximum number of threads to use for writing data to tablet servers of
the FATE system table.",
+ "4.0.0", false),
Review Comment:
What's a good default val for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
