keith-turner commented on code in PR #5670:
URL: https://github.com/apache/accumulo/pull/5670#discussion_r2162350161
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java:
##########
@@ -834,6 +834,17 @@ public ConditionalWriter createConditionalWriter(String
tableName) throws TableN
return createConditionalWriter(tableName, null);
}
+ public ConditionalWriter createConditionalWriterForFateTable(String
tableName)
+ throws TableNotFoundException {
+ ConditionalWriterImpl writer = (ConditionalWriterImpl)
createConditionalWriter(tableName);
Review Comment:
Should use the ConditionalWriterConfig() object to set the number of
threads, like the following.
```java
AccumuloClient client = ...;
var cwConfig = new
ConditionalWriterConfig().setMaxWriteThreads(maxThreads);
client.createConditionalWriter(table, cwConfig);
```
Why add this method to client context instead of somewhere in the fate code?
##########
core/src/main/java/org/apache/accumulo/core/conf/ClientProperty.java:
##########
@@ -81,6 +81,10 @@ public enum ClientProperty {
"2.1.0", false),
CONDITIONAL_WRITER_THREADS_MAX("conditional.writer.threads.max", "3",
PropertyType.COUNT,
"Maximum number of threads to use for writing data to tablet servers.",
"2.1.0", false),
+
CONDITIONAL_WRITER_THREADS_MAX_FATE_TABLE("conditional.writer.threads.max.fate.table",
"3",
Review Comment:
This should be a server property and not a client property. In actual use
it will only impact the manager process. Also it seems like the property
should have a fate prefix like `manager.fate.onditional.writer.threads`. Then
it would sort together w/ the other fate props.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
