kevinrr888 commented on code in PR #5662:
URL: https://github.com/apache/accumulo/pull/5662#discussion_r2161975968
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java:
##########
@@ -772,15 +761,8 @@ public void run() {
}
}
- public String getClientAddressString() {
- if (clientAddress == null) {
- return null;
- }
- return clientAddress.getHost() + ":" + clientAddress.getPort();
- }
-
public TServerInstance getTabletSession() {
- String address = getClientAddressString();
+ String address = getAdvertiseAddress().toString();
if (address == null) {
Review Comment:
address cannot be null here. Probably want .equals("null") (if changing this
to `String.valueOf(getAdvertiseAddress())`) or check if getAdvertiseAddress()
== null at the start of the method (I prefer the latter)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
