dlmarion commented on code in PR #5662:
URL: https://github.com/apache/accumulo/pull/5662#discussion_r2175015339
##########
server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java:
##########
@@ -311,6 +329,17 @@ protected void updateAdvertiseAddress(HostAndPort
thriftBindAddress) {
}
}
+ protected void startThriftServer(ThriftServerSupplier supplier, boolean
start)
+ throws UnknownHostException {
+ thriftServer = supplier.get();
+ if (start) {
+ thriftServer.startThriftServer("Thrift Client Server");
+ log.debug("Starting {} listening on {}", this.getClass().getSimpleName(),
+ thriftServer.address);
Review Comment:
I think it's fine because the server classes have log messages too, like
this one in the Manager
```
log.info("Started Manager client service at {}", getAdvertiseAddress());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
