dlmarion commented on code in PR #5726:
URL: https://github.com/apache/accumulo/pull/5726#discussion_r2194780884
##########
server/base/src/main/java/org/apache/accumulo/server/compaction/FileCompactor.java:
##########
@@ -560,9 +582,15 @@ private void compactLocalityGroup(String lgName,
Set<ByteSequence> columnFamilie
SystemIteratorEnvironment iterEnv =
env.createIteratorEnv(context, acuTableConf, getExtent().tableId());
- SortedKeyValueIterator<Key,Value> itr =
iterEnv.getTopLevelIterator(IteratorConfigUtil
- .convertItersAndLoad(env.getIteratorScope(), cfsi, acuTableConf,
iterators, iterEnv));
+ SortedKeyValueIterator<Key,Value> stack = null;
+ try {
+ stack = IteratorConfigUtil.convertItersAndLoad(env.getIteratorScope(),
cfsi, acuTableConf,
Review Comment:
Looking at the code path, `ClassLoaderUtil.loadClass` would get the
ClassLoader, but calling `ClassLoader.loadClass` would throw a
`ClassNotFoundException`, which is not a RuntimeException. I think it would
fail the compaction, pick up the next one, and keep failing until the
configuration is fixed. Do you think we should add ReflectiveOperationException
to this catch clause so that Compactors die if there is *any* issue loading
iterator classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
