dlmarion commented on code in PR #5734:
URL: https://github.com/apache/accumulo/pull/5734#discussion_r2200457649
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/AssignmentHandler.java:
##########
@@ -98,7 +98,10 @@ public void run() {
}
server.unopenedTablets.remove(extent);
- server.openingTablets.add(extent);
+
+ if (!server.openingTablets.add(extent)) {
+ return;
Review Comment:
Do you need the return here? It's the last statement in the method and not
in a loop or anything.
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/OpeningTablets.java:
##########
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.accumulo.tserver;
+
+import java.util.Collections;
+import java.util.EnumSet;
+import java.util.Set;
+import java.util.SortedSet;
+import java.util.TreeSet;
+
+import org.apache.accumulo.core.dataImpl.KeyExtent;
+import org.apache.accumulo.core.metadata.schema.Ample;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.base.Preconditions;
+
+public class OpeningTablets {
+ private static final Logger log =
LoggerFactory.getLogger(OpeningTablets.class);
+
+ // Tracks the set of data levels that are shutting down and can not load new
tablets.
+ final Set<Ample.DataLevel> shutdownDataLevels =
EnumSet.noneOf(Ample.DataLevel.class);
+ final SortedSet<KeyExtent> openingTablets = new TreeSet<>();
+
+ public synchronized boolean add(KeyExtent extent) {
+ if (shutdownDataLevels.contains(Ample.DataLevel.of(extent.tableId()))) {
+ log.info("ignoring request to load {} because the data level is
shutdown", extent);
Review Comment:
Manager tells TabletServer to host tablet and TabletServer silently ignores.
The Manager won't do anything with that tablet until the TabletServer reports
it as hosted, which won't happen. What does the Manager do if the Tablet is not
hosted for some amount of time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
