ddanielr commented on PR #5785: URL: https://github.com/apache/accumulo/pull/5785#issuecomment-3168605446
> > Do we need to make release notes changes for finalizing any of the classes that are defined in our public API? > > That is a good question. I am not sure. > I think feedback regarding the method of fixing this warning would be helpful (making the class final vs. adding the `finalize()` method). I tried to only make things final if it was an inner class and/or something that seemed very unlikely to be subclassed, however I just used my best judgement so would like others input on this part. I don't see an issue with finalizing the default implementation classes since users should be implementing new classes from the interface rather than extending the clientImpl classes. Since finalize() is deprecated, does this SpotBugs warning go away if we were to switch to a newer java version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
