DomGarguilo commented on code in PR #5785:
URL: https://github.com/apache/accumulo/pull/5785#discussion_r2274381697
##########
core/pom.xml:
##########
@@ -242,6 +242,13 @@
</plugins>
</pluginManagement>
<plugins>
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <configuration>
+ <omitVisitors>SharedVariableAtomicityDetector</omitVisitors>
Review Comment:
I would argue that each serves a different purpose. To me it seems the
filters in exclude-filter.xml are more or less permanent for code that we don't
expect to change where as this new `<omitVisitors>` approach is a nice way to
temporarily omit these detectors while we are fixing them. If we find that we
want to permanently omit these detectors than I think it would be a good idea
to move things into the xml file but for now this seems to work well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
