ddanielr commented on PR #5807: URL: https://github.com/apache/accumulo/pull/5807#issuecomment-3197603778
> > In 4.0, the [CompactionJobPrioritizer](https://github.com/apache/accumulo/blob/582da789ac97a56fa313fa71fe109eb8f44bafc9/core/src/main/java/org/apache/accumulo/core/util/compaction/CompactionJobPrioritizer.java#L37-L36) was updated to determine the correct compaction job priority across all tables, removed the need to have separate meta and root compaction services. > > Thanks, I forgot about that change. If the user wants to use the `default` group for the `root` and `metadata` tables, then they would need to define the old `root` and `meta` compaction services for the purpose of the upgrade, then change the tables' `table.compaction.dispatcher.opts.` properties afterwards to use the `default` compaction service. yep! The actual `root` and `meta` compaction services are only defined in the default configuration. An upgrade to 4.0 would change the default config, but if the two compaction services are defined in zookeeper or the manager's instance.properties file then the upgrade would proceed as expected. > I wonder if this PR should be updated to validate only the user tables compaction service configuration, and then in a different PR add a method to the 4.0 upgrade code that removes root and meta compaction dispatcher properties if they match the ones added in the 2.1 InitialConfiguration class. I think having the upgrade code validate all table compaction services is a good improvement. If a compaction service is malformed then we can't really do an auto fix for that, other than full deletion. But, instead of matching and removing properties based on old values, the upgrader could throw a warning and exit like what you've done here. And on `--force` it just changes the dispatcher property value to be `default` for any undefined compaction service name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
