ddanielr commented on PR #5807: URL: https://github.com/apache/accumulo/pull/5807#issuecomment-3197856656
> Thinking about the following changes @ddanielr , wanted to get your thoughts: > > In `accumulo upgrade --start`, validate the compaction service configurations and: > > 1. If it's the root or metadata table, and the `root` and `meta` compaction service configurations don't exist, then WARN that on an upgrade they will be set to the default (this is the behavior when initializing a new 4.0 instance). This would allow the user to fix right here and re-run `accumulo upgrade --start` to resolve the warnings. I like that! Any warn messages from the upgrader should be reviewed in general and the upgrader would be returning the system to a "typical" deployment state. > 2. If it's any other table, then FAIL like the code currently does. Agreed! > In `Upgrader12to13.upgradeZooKeeper`, run the same compaction service validation code for root and meta and remove the 2.1 and 3.0 properties if the compaction service does not exist. Removing the properties will revert the root and metadata back to the default configuration. I like the behavior of removing properties and relying on the defaults. That seems less prone to error vs coming up with new property definitions and setting them explicitly on the table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
