keith-turner commented on code in PR #5909:
URL: https://github.com/apache/accumulo/pull/5909#discussion_r2369363018
##########
core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java:
##########
@@ -271,7 +274,7 @@ public void getProperties(Map<String,String> props,
Predicate<String> filter) {
public void getProperties(Map<String,String> props, Predicate<String> filter,
boolean useDefaults) {
if (useDefaults) {
- parent.getProperties(props, filter);
+ parent.getProperties(props, DEFAULT_TABLE_PROP_FILTER.and(filter));
Review Comment:
This makes one method filter table props while other methods like
SiteConfiguration.get() do filter.
This is really big change in behavior, code was written w/ the expecation
that SiteConfiguration presents a merged view of Site+Default and this makes a
large change in that expecation. I do not have a good sense of how this change
will ripple through the code. Its ok to have table props in default, but not
site. So what does that mean for the merged view?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
