ctubbsii commented on code in PR #5909:
URL: https://github.com/apache/accumulo/pull/5909#discussion_r2370194474
##########
core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java:
##########
@@ -271,7 +274,7 @@ public void getProperties(Map<String,String> props,
Predicate<String> filter) {
public void getProperties(Map<String,String> props, Predicate<String> filter,
boolean useDefaults) {
if (useDefaults) {
- parent.getProperties(props, filter);
+ parent.getProperties(props, DEFAULT_TABLE_PROP_FILTER.and(filter));
Review Comment:
It looks like this would prevent TableConfiguration.getProperties() from
being able to express/return a default value inherited from the
DefaultConfiguration. I think this isn't something we should do. The only
reason we have this option to exclude defaults from the parent at all, is to
support the `bin/accumulo init --upload-accumulo-props` flag (because we don't
want to upload the values that the user didn't set to ZK). In all other cases,
we need to return all the defaults, so it gets propagated down to
NamespaceConfiguration and TableConfiguration when they pull from the parents
in the config hierarchy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
