dlmarion commented on code in PR #5935:
URL: https://github.com/apache/accumulo/pull/5935#discussion_r2383181313
##########
core/src/main/java/org/apache/accumulo/core/client/admin/compaction/CompactableFile.java:
##########
@@ -52,12 +52,4 @@ static CompactableFile create(URI uri, long estimatedSize,
long estimatedEntries
return new CompactableFileImpl(uri, estimatedSize, estimatedEntries);
}
- /**
- * Creates a new CompactableFile object that implements this interface.
- *
- * @since 4.0.0
- */
- static CompactableFile create(URI uri, Range range, long estimatedSize, long
estimatedEntries) {
Review Comment:
The remaining `CompactableFile.create` method is only used in tests and in
`RatioBasedCompactionPlanner.FakeFileGenerator`. Are users expected to create
CompactableFile implementations? If not, I'm thinking that these `create`
methods on the interface should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
