keith-turner commented on code in PR #5935:
URL: https://github.com/apache/accumulo/pull/5935#discussion_r2383037445
##########
core/src/main/java/org/apache/accumulo/core/client/admin/compaction/CompactableFile.java:
##########
@@ -52,12 +52,4 @@ static CompactableFile create(URI uri, long estimatedSize,
long estimatedEntries
return new CompactableFileImpl(uri, estimatedSize, estimatedEntries);
}
- /**
- * Creates a new CompactableFile object that implements this interface.
- *
- * @since 4.0.0
- */
- static CompactableFile create(URI uri, Range range, long estimatedSize, long
estimatedEntries) {
Review Comment:
This is public API, should probably keep and maybe add test.
##########
core/src/main/java/org/apache/accumulo/core/spi/balancer/DoNothingBalancer.java:
##########
@@ -38,10 +38,6 @@ public DoNothingBalancer() {
this.tableId = null;
}
- public DoNothingBalancer(TableId tableId) {
Review Comment:
This may be used by reflection code in per table balancers. There is code
that expects this constructor and looks for it via reflection.
##########
core/src/main/java/org/apache/accumulo/core/client/summary/SummarizerConfiguration.java:
##########
@@ -160,15 +160,6 @@ public static Map<String,String>
toTableProperties(SummarizerConfiguration... co
return SummarizerConfigurationUtil.toTablePropertiesMap(new
ArrayList<>(configurations));
}
- /**
- * Decodes table properties with the prefix {@code table.summarizer} into
- * {@link SummarizerConfiguration} objects. Table properties with prefixes
other than
- * {@code table.summarizer} are ignored.
- */
- public static Collection<SummarizerConfiguration>
fromTableProperties(Map<String,String> props) {
Review Comment:
This is public API, should probably keep and use in test.
##########
core/src/main/java/org/apache/accumulo/core/client/TableOfflineException.java:
##########
@@ -24,13 +24,6 @@ public class TableOfflineException extends RuntimeException {
private static final long serialVersionUID = 1L;
- /**
- * @since 2.0.0
- */
- public TableOfflineException(String msg) {
Review Comment:
This is public API should probably keed and add test or deprecate.
##########
core/src/main/java/org/apache/accumulo/core/client/rfile/RFileWriter.java:
##########
@@ -130,15 +130,6 @@ public void startNewLocalityGroup(String name,
List<byte[]> families) throws IOE
_startNewLocalityGroup(name, fams);
}
- /**
- * See javadoc for {@link #startNewLocalityGroup(String, List)}
- *
- * @throws IllegalStateException When default locality group already started.
- */
- public void startNewLocalityGroup(String name, byte[]... families) throws
IOException {
Review Comment:
This is public API, should probably keep and use in test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
