ctubbsii commented on code in PR #5916:
URL: https://github.com/apache/accumulo/pull/5916#discussion_r2370485308
##########
server/base/src/main/java/org/apache/accumulo/server/conf/TableConfiguration.java:
##########
@@ -81,28 +80,6 @@ public TableConfiguration(ServerContext context, TableId
tableId, NamespaceConfi
newDeriver(conf -> createCryptoService(conf, tableId,
context.getCryptoFactory()));
}
- @Override
- public String get(Property property) {
- String value = _get(property);
- if (value != null) {
- return value;
- }
- AccumuloConfiguration parent = getParent();
- if (parent != null) {
- return parent.get(property);
- }
- return null;
- }
-
- @Nullable
- private String _get(Property property) {
- Map<String,String> propMap = getSnapshot();
- if (propMap == null) {
Review Comment:
It's not possible. It's always non-null. We even have a `@NonNull`
annotation to signal that. The ZooBasedConfiguration didn't bother to check it
for that reason, but this code was too far distant, so I guess it diverged a
bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
