keith-turner commented on code in PR #5916:
URL: https://github.com/apache/accumulo/pull/5916#discussion_r2370426361
##########
server/base/src/main/java/org/apache/accumulo/server/conf/TableConfiguration.java:
##########
@@ -81,28 +80,6 @@ public TableConfiguration(ServerContext context, TableId
tableId, NamespaceConfi
newDeriver(conf -> createCryptoService(conf, tableId,
context.getCryptoFactory()));
}
- @Override
- public String get(Property property) {
- String value = _get(property);
- if (value != null) {
- return value;
- }
- AccumuloConfiguration parent = getParent();
- if (parent != null) {
- return parent.get(property);
- }
- return null;
- }
-
- @Nullable
- private String _get(Property property) {
- Map<String,String> propMap = getSnapshot();
- if (propMap == null) {
Review Comment:
Compared this removed code w/ the code in ZooBasedConfiguration. The code
in ZooBasedConfiguration would throw a NPE if `getSnapshot()` returned null.
AFACIT this is the only difference. This seems sketchy, was this a bug? 2.1
has the same behavior wondering if any change is needed there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
