kevinrr888 commented on code in PR #5990:
URL: https://github.com/apache/accumulo/pull/5990#discussion_r2566651438
##########
core/src/main/java/org/apache/accumulo/core/client/admin/NewTableConfiguration.java:
##########
@@ -168,7 +168,7 @@ public Map<String,String> getProperties() {
Map<String,String> propertyMap = new HashMap<>();
if (limitVersion) {
-
propertyMap.putAll(IteratorConfigUtil.generateInitialTableProperties(limitVersion));
+ propertyMap.putAll(IteratorConfigUtil.getInitialTableProperties());
}
Review Comment:
I deprecated `withoutDefaultIterators()` and `-ndi` option and added
`withoutDefaults()` and `-ndtp` in 797e39102700e1d187635fdd7d0fe0c0a8d1c721 and
18914a58d1206bed87cc2d6e8e299d629607a3c2 (same functionality as before, but
more appropriate name)
Also considered deprecating `withoutDefaultIterators()` and:
* adding both `withoutDefaults()` and `withoutDefaultIters()` but thought
that would probably add too much bloat (probably fine if there's desire for it)
* adding only `withoutDefaultIters()`, but like you said we probably don't
want to change functionality
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
