kevinrr888 commented on code in PR #5990:
URL: https://github.com/apache/accumulo/pull/5990#discussion_r2566661506
##########
shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java:
##########
@@ -185,6 +188,18 @@ public int execute(final String fullCommand, final
CommandLine cl, final Shell s
shellState.getAccumuloClient().tableOperations().create(tableName,
ntc.setTimeType(timeType).setProperties(initProperties));
+ // any default properties not in the src table should also not be in the
dest table.
+ // Need to remove these after table creation.
+ if (cl.hasOption(createTableOptCopyConfig.getOpt())) {
+ var defaultProps =
IteratorConfigUtil.getInitialTableProperties().keySet();
+ Preconditions.checkState(srcTableConfig != null);
+ for (var defaultProp : defaultProps) {
+ if (srcTableConfig.get(defaultProp) == null) {
+
shellState.getAccumuloClient().tableOperations().removeProperty(tableName,
defaultProp);
+ }
+ }
+ }
Review Comment:
Yeah good point, changed in 797e39102700e1d187635fdd7d0fe0c0a8d1c721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
