kevinrr888 commented on code in PR #5999:
URL: https://github.com/apache/accumulo/pull/5999#discussion_r2585821616
##########
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloConfigImpl.java:
##########
@@ -681,6 +687,38 @@ public Map<String,String> getSystemProperties() {
return new HashMap<>(systemProperties);
}
+ /**
+ * Add a JVM option to the spawned JVM processes. The default set of JVM
options contains
+ * '-XX:+PerfDisableSharedMem' and '-XX:+AlwaysPreTouch'
+ *
+ * @param option JVM option
+ * @since 2.1.5
+ */
+ public void addJvmOption(String option) {
+ this.jvmOptions.add(option);
+ }
Review Comment:
Could potentially do some sort of regex validation. E.g., accept memory
flags, system props, and/or XX flags. One thing I noticed is Xmx is set
elsewhere, so maybe want to avoid accepting that here (direct to
`setDefaultMemory()`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
