keith-turner commented on code in PR #5999:
URL: https://github.com/apache/accumulo/pull/5999#discussion_r2586010998
##########
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloConfigImpl.java:
##########
@@ -681,6 +687,38 @@ public Map<String,String> getSystemProperties() {
return new HashMap<>(systemProperties);
}
+ /**
+ * Add a JVM option to the spawned JVM processes. The default set of JVM
options contains
+ * '-XX:+PerfDisableSharedMem' and '-XX:+AlwaysPreTouch'
+ *
+ * @param option JVM option
+ * @since 2.1.5
Review Comment:
These since tags are not required because this is not a public API class.
Does not hurt to have them, but it is something to maintain going forward.
##########
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterImpl.java:
##########
@@ -356,14 +357,13 @@ private ProcessInfo _exec(Class<?> clazz, List<String>
extraJvmOpts, String... a
var hardcodedArgs = Stream.of(
"-Dapple.awt.UIElement=true",
Review Comment:
Why not add these two options to the set of defaults? Then could have no
hard coded jvm options and all jvm options can be mutated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
