ddanielr commented on code in PR #6004:
URL: https://github.com/apache/accumulo/pull/6004#discussion_r2590531293
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -280,7 +280,11 @@ public enum Property {
"The maximum size of a message that can be sent to a server.", "1.5.0"),
@Experimental
GENERAL_OPENTELEMETRY_ENABLED("general.opentelemetry.enabled", "false",
PropertyType.BOOLEAN,
- "Enables tracing functionality using OpenTelemetry (assuming
OpenTelemetry is configured).",
+ "Enables tracing of actions initiated by the process using OpenTelemetry
(assuming OpenTelemetry is "
+ + "configured). When this property is false, RPC request that arrive
at a process with tracing set will "
+ + "still emit traces as long as OpenTelemetry is properly
configured. For example if this property is only "
Review Comment:
```suggestion
+ "still emit traces as long as OpenTelemetry is properly
configured. For example, if this property is only "
```
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -280,7 +280,11 @@ public enum Property {
"The maximum size of a message that can be sent to a server.", "1.5.0"),
@Experimental
GENERAL_OPENTELEMETRY_ENABLED("general.opentelemetry.enabled", "false",
PropertyType.BOOLEAN,
- "Enables tracing functionality using OpenTelemetry (assuming
OpenTelemetry is configured).",
+ "Enables tracing of actions initiated by the process using OpenTelemetry
(assuming OpenTelemetry is "
+ + "configured). When this property is false, RPC request that arrive
at a process with tracing set will "
+ + "still emit traces as long as OpenTelemetry is properly
configured. For example if this property is only "
+ + "set for the Accumulo GC server, then all RPCs initiated by the GC
would emit trace data across the "
+ + "cluster. However actions initiated on the manager process would
not cause any tracing activity.",
Review Comment:
```suggestion
+ "cluster. However, actions initiated on the manager process
would not cause any tracing activity.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
