ctubbsii commented on code in PR #6004:
URL: https://github.com/apache/accumulo/pull/6004#discussion_r2593439014
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -280,7 +280,13 @@ public enum Property {
"The maximum size of a message that can be sent to a server.", "1.5.0"),
@Experimental
GENERAL_OPENTELEMETRY_ENABLED("general.opentelemetry.enabled", "false",
PropertyType.BOOLEAN,
- "Enables tracing functionality using OpenTelemetry (assuming
OpenTelemetry is configured).",
+ "Enables tracing for all spans in the process using OpenTelemetry
(assuming OpenTelemetry is "
+ + "configured). When true, if a thread with no active trace
encounters a span, then a new trace with "
+ + "a new id is started. When this property is false, RPC requests
that arrive at a process with tracing "
+ + "set will still emit traces for all spans as long as OpenTelemetry
is properly configured. For example, "
+ + "if this property is only set for the Accumulo GC server, then all
RPCs initiated by the GC would emit "
+ + "trace data across the cluster. However, threads on non gc server
processes with no active trace would "
+ + "not emit anything when they encounter a span.",
Review Comment:
I wonder if this could be more succinct. Something like:
```suggestion
"Enables OpenTelemetry traces for new spans in the server process that
are not already part of "
+ "an existing trace. Spans that are part of an existing trace,
such as one originating in client code "
+ "and propagated to the server over an RPC request, are always
traced, regardless of this value. "
+ "(Note: no tracing will occur if OpenTelemetry is not first
configured for the JVM).",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
