dlmarion commented on code in PR #93:
URL: https://github.com/apache/accumulo-access/pull/93#discussion_r2643717897
##########
core/src/main/java/org/apache/accumulo/access/impl/MultiAccessEvaluatorImpl.java:
##########
@@ -46,21 +45,26 @@ private MultiAccessEvaluatorImpl(Collection<Authorizations>
authorizationSets) {
@Override
public boolean canAccess(String accessExpression) throws
InvalidAccessExpressionException {
- return canAccess(accessExpression.getBytes(UTF_8));
+ return canAccess(AccessExpression.of(accessExpression));
}
@Override
public boolean canAccess(byte[] accessExpression) throws
InvalidAccessExpressionException {
+ return canAccess(AccessExpression.of(accessExpression));
+ }
+
+ @Override
+ public boolean canAccess(AccessExpression accessExpression) {
+ return canAccess(accessExpression.parse());
Review Comment:
I think with the suggested change above, this issue is OBE. AccessEvaluator
will only evaluate using the parse tree if parse() has been called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
