dlmarion commented on PR #93:
URL: https://github.com/apache/accumulo-access/pull/93#issuecomment-3705375839
No, I don't think so. The benchmark currently contains methods that do the
following:
1. Validates an AccessExpression from a byte[]
2. Validates an AccessExpression from a String
3. Times AccessEvaluator.canAccess(byte[]) for different evaluators and
expressions.
4. Times VisibilityEvaluator.evaluate from a pre-constructed
ColumnVisibility
5. Times VisibilityEvaluator.evaluate from a newly constructed
ColumnVisibility
Tests 1, 2, and 3 all end up calling
`ParserEvaluator.parseAccessExpression` for each expression. If an expression
is tested multiple times, then it will be re-parsed. I don't think the
expressions are reused in the benchmark tests. Also, I think we recommend
caching the result of the canAccess call for an expression outside of
Accumulo-Access to avoid redundant work.
ParsedAccessExpression, and it's parse tree, are not used anywhere that I
can tell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
