keith-turner commented on code in PR #6049:
URL: https://github.com/apache/accumulo/pull/6049#discussion_r2683239704
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -450,6 +450,10 @@ public enum Property {
"The number of threads used to run fault-tolerant executions (FATE)."
+ " These are primarily table operations like merge.",
"1.4.3"),
+ MANAGER_MAX_TSERVER_HALTS("manager.max.tservers.halts", "0",
PropertyType.COUNT,
Review Comment:
Counts can be hard to reason about because you have no idea how long it will
take to do X counts. Like if this was set to 3, three attempts could happen in
50ms or take 30min. For the 50ms case, you would probably want to give it a
bit more time before deleting the lock. For the 30min case, may want to delete
the lock before doing 3 attempts. A combo of time and attempts seems best, but
not sure how to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
