ddanielr commented on code in PR #6049:
URL: https://github.com/apache/accumulo/pull/6049#discussion_r2683682841
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1190,15 +1194,31 @@ private List<TabletMigration>
checkMigrationSanity(Set<TabletServerId> current,
> MAX_BAD_STATUS_COUNT) {
if (shutdownServerRateLimiter.tryAcquire()) {
log.warn("attempting to stop {}", server);
+ if (forceHaltingEnabled
+ && (haltedServers.computeIfAbsent(server, s -> new
AtomicInteger(0))
+ .incrementAndGet() > maxTserverHalts)) {
+ log.warn("tserver {} is not responding to halt requests,
deleting zlock", server);
+ var zk = getContext().getZooReaderWriter();
+ var iid = getContext().getInstanceID();
+ String tserversPath = Constants.ZROOT + "/" + iid +
Constants.ZTSERVERS;
+ try {
+ ServiceLock.deleteLocks(zk, tserversPath,
server.getHostAndPort()::equals,
+ log::info, false);
+ } catch (KeeperException | InterruptedException e) {
+ log.error("Failed to delete zlock for server {}", server);
+ }
+ haltedServers.remove(server);
+ }
Review Comment:
Yep I see that.
I'll add an else clause so it doesn't attempt the rpc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
