kevinrr888 commented on code in PR #6025:
URL: https://github.com/apache/accumulo/pull/6025#discussion_r2736894595
##########
core/src/main/java/org/apache/accumulo/core/fate/zookeeper/DistributedReadWriteLock.java:
##########
@@ -107,6 +109,7 @@ public interface QueueLock {
private static final Logger log =
LoggerFactory.getLogger(DistributedReadWriteLock.class);
+ @NotThreadSafe
Review Comment:
There has been some discussion around this class:
https://github.com/apache/accumulo/pull/6025#discussion_r2624917759
https://github.com/apache/accumulo/pull/6025#discussion_r2624926975
Threads never share the same ~~DistributedReadWriteLock~~ ReadLock, so needs
to be marked not thread safe as it has concurrency issues if this were to be
shared b/w threads
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
