keith-turner commented on code in PR #6025:
URL: https://github.com/apache/accumulo/pull/6025#discussion_r2737290390
##########
server/base/src/main/java/org/apache/accumulo/server/tablets/TabletTime.java:
##########
@@ -87,6 +89,8 @@ public MetadataTime getMetadataTime(long time) {
}
@Override
+ @SuppressFBWarnings(value = "AT_NONATOMIC_64BIT_PRIMITIVE",
+ justification = "this is only called in tablet constructor, so does
not need to be done atomically")
public void useMaxTimeFromWALog(long time) {
Review Comment:
Would making this method syncronized remove the warning? Seems safe to add
the sync and it makes the code more tolerant of changes in how its used.
```suggestion
public synchronized void useMaxTimeFromWALog(long time) {
```
Also seems like the following methods in this class should be made
synchronized because they read and/or write the instance variables.
- `MetadataTime getMetadataTime()`
- `public long getTime()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
