kevinrr888 commented on code in PR #5348:
URL: https://github.com/apache/accumulo/pull/5348#discussion_r2737610907
##########
server/base/src/main/java/org/apache/accumulo/server/util/checkCommand/SystemConfigCheckRunner.java:
##########
@@ -30,10 +41,167 @@ public Admin.CheckCommand.CheckStatus
runCheck(ServerContext context, ServerUtil
boolean fixFiles) throws Exception {
Admin.CheckCommand.CheckStatus status = Admin.CheckCommand.CheckStatus.OK;
printRunning();
+
+ log.trace("********** Checking validity of some ZooKeeper nodes
**********");
+ status = checkZkNodes(context, status);
Review Comment:
I'd be fine with this as a follow-on. I went with the current approach
because there's multiple statuses of a check:
```
public enum CheckStatus {
OK, FAILED, SKIPPED_DEPENDENCY_FAILED, FILTERED_OUT;
}
```
Running a check will only produce OK or FAILED (the other statuses are if a
check is skipped/not run), so this could be converted to bool, but may make
things a bit less clear in my opinion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
