dlmarion commented on code in PR #5348:
URL: https://github.com/apache/accumulo/pull/5348#discussion_r2737973825
##########
server/base/src/main/java/org/apache/accumulo/server/util/checkCommand/SystemConfigCheckRunner.java:
##########
@@ -30,10 +41,167 @@ public Admin.CheckCommand.CheckStatus
runCheck(ServerContext context, ServerUtil
boolean fixFiles) throws Exception {
Admin.CheckCommand.CheckStatus status = Admin.CheckCommand.CheckStatus.OK;
printRunning();
+
+ log.trace("********** Checking validity of some ZooKeeper nodes
**********");
+ status = checkZkNodes(context, status);
Review Comment:
From what I could find `SKIPPED_DEPENDENCY_FAILED` and `FILTERED_OUT` were
only used in the code that you see below:
https://github.com/apache/accumulo/blob/c1dec0018cf9f8d2e12ffc4bfa6ec47dc2e655b9/server/base/src/main/java/org/apache/accumulo/server/util/Admin.java#L1428-L1461
If `runCheck` on line 1439 returned a boolean, then you could convert that
to `OK` or `FAILED` at that time and I think it would make the checks a little
easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
