keith-turner commented on code in PR #6111:
URL: https://github.com/apache/accumulo/pull/6111#discussion_r2795507927
##########
core/src/main/java/org/apache/accumulo/core/iteratorsImpl/IteratorProperty.java:
##########
@@ -113,9 +113,7 @@ public IteratorSetting toSetting() {
}
private static void check(boolean b, String property, String value) {
- if (!b) {
- throw new IllegalArgumentException("Illegal iterator property: " +
property + "=" + value);
- }
+ Preconditions.checkArgument(b, "Illegal iterator property: " + property +
"=" + value);
Review Comment:
Want to avoid constructing the string unless needed, the following might do
that.
```suggestion
Preconditions.checkArgument(b, "Illegal iterator property: %s=%s "
,property,value);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
