keith-turner commented on code in PR #6111:
URL: https://github.com/apache/accumulo/pull/6111#discussion_r2795564658
##########
core/src/main/java/org/apache/accumulo/core/iteratorsImpl/IteratorProperty.java:
##########
@@ -144,15 +144,22 @@ public static IteratorProperty parse(String property,
String value) {
check(iterPropParts.length == 4 || iterPropParts.length == 6, property,
value);
IteratorUtil.IteratorScope scope =
IteratorUtil.IteratorScope.valueOf(iterPropParts[2]);
String iterName = iterPropParts[3];
+ check(!iterName.isEmpty(), property, value);
if (iterPropParts.length == 4) {
- String[] valTokens = value.split(",");
+ String[] valTokens = value.split(",", -1);
Review Comment:
>I think in that case it won't make a difference. Without the -1, the
trailing empty segments are dropped and the length check will already fail.
w/o the `-1` maybe an odd property like
`table.iterator.scan......otherName=20,some.classname` would pass checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
