dlmarion commented on code in PR #6134: URL: https://github.com/apache/accumulo/pull/6134#discussion_r2824754814
########## server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/sservers.ftl: ########## @@ -0,0 +1,50 @@ +<#-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + https://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> + <div class="row"> + <div class="col-xs-12"> + <h3>${title}</h3> + </div> + </div> + <div class="row"> + <div class="col-xs-12"> + <table id="sservers" class="table caption-top table-bordered table-striped table-condensed"> + <caption><span class="table-caption">Online Scan Servers</span><br /> Review Comment: I think we can remove "Online" from the page caption. ########## server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/js/sservers.js: ########## @@ -0,0 +1,243 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +/* JSLint global definitions */ +/*global + $, sessionStorage, timeDuration, bigNumberForQuantity, bigNumberForSize, ajaxReloadTable, + getGroups, getSserversDetail +*/ +"use strict"; + +var sserversTable; +var SSERVERS_SESSION_KEY = 'sservers'; + +var METRICS = { + OPEN_FILES: 'accumulo.scan.files.open', + QUERIES: 'accumulo.scan.queries', + SCANNED_ENTRIES: 'accumulo.scan.query.scanned.entries', + QUERY_RESULTS: 'accumulo.scan.query.results', + QUERY_RESULTS_BYTES: 'accumulo.scan.query.results.bytes', + BUSY_TIMEOUTS: 'accumulo.scan.busy.timeout.count', + RESERVATION_CONFLICTS: 'accumulo.scan.reservation.conflict.count', + ZOMBIE_THREADS: 'accumulo.scan.zombie.threads' +}; Review Comment: I think we should add the following: accumulo.server.idle - binary condition applicable to compactors and tservers too accumulo.detected.low.memory - binary condition applicable to compactors and tservers too accumulo.scan.paused.for.memory - applicable to tservers too accumulo.scan.return.early.for.memory - applicable to tservers too For reference the minc_paused is relevant to tservers and majc_paused is relevant to compactors, and both are related to low memory conditions as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
