DomGarguilo commented on code in PR #6134: URL: https://github.com/apache/accumulo/pull/6134#discussion_r2828718689
########## server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/js/sservers.js: ########## @@ -0,0 +1,243 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +/* JSLint global definitions */ +/*global + $, sessionStorage, timeDuration, bigNumberForQuantity, bigNumberForSize, ajaxReloadTable, + getGroups, getSserversDetail +*/ +"use strict"; + +var sserversTable; +var SSERVERS_SESSION_KEY = 'sservers'; + +var METRICS = { + OPEN_FILES: 'accumulo.scan.files.open', + QUERIES: 'accumulo.scan.queries', + SCANNED_ENTRIES: 'accumulo.scan.query.scanned.entries', + QUERY_RESULTS: 'accumulo.scan.query.results', + QUERY_RESULTS_BYTES: 'accumulo.scan.query.results.bytes', + BUSY_TIMEOUTS: 'accumulo.scan.busy.timeout.count', + RESERVATION_CONFLICTS: 'accumulo.scan.reservation.conflict.count', + ZOMBIE_THREADS: 'accumulo.scan.zombie.threads' +}; Review Comment: Sounds good. Im thinking two tables might make sense for the sserver page at least. One "Throughput" table and one "Conditions" table. The table on the sservers page is already pretty cramped and making this split seems to make sense to me. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
