keith-turner commented on code in PR #6168:
URL: https://github.com/apache/accumulo/pull/6168#discussion_r2885546995
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -958,6 +975,26 @@ public void run() {
throw new IllegalStateException("Unable to start server on host " +
getBindAddress(), e);
}
+ tserverSet.startListeningForTabletServerChanges(this);
+
+ MetricsInfo metricsInfo = getContext().getMetricsInfo();
+
+ try {
+ // Acquire the lock that all managers get before the primary lock, this
allows non primary
+ // manager processes to work on stuff.
+ getManagerLock();
+ } catch (KeeperException | InterruptedException e) {
+ throw new IllegalStateException("Unable to get manager lock ", e);
+ }
+
+ fateWorker.setLock(managerLock);
+
+ metricsInfo
+ .addMetricsProducers(fateWorker.getMetricsProducers().toArray(new
MetricsProducer[0]));
+
+ metricsInfo.init(MetricsInfo.serviceTags(getContext().getInstanceName(),
getApplicationName(),
+ getAdvertiseAddress(), getResourceGroup()));
+
Review Comment:
That seems like a good change, could be done in a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
