keith-turner commented on code in PR #6168:
URL: https://github.com/apache/accumulo/pull/6168#discussion_r2891111974
##########
core/src/main/java/org/apache/accumulo/core/lock/ServiceLockPaths.java:
##########
@@ -287,6 +296,11 @@ public Set<ServiceLockPath>
getCompactor(ResourceGroupPredicate resourceGroupPre
return get(Constants.ZCOMPACTORS, resourceGroupPredicate, address,
withLock);
}
+ public Set<ServiceLockPath> getManagerAssistants(ResourceGroupPredicate
resourceGroupPredicate,
Review Comment:
Improved the naming consistency in 0556afaa8e0c3190f22cc7c5e4aeec02f4689ee9
> Is it the case that clients will only always connect to the primary
manager, so that is why it's called Manager?
Currently clients only talk to the primary manager. In a follow on would
like to create a new thrift service, maybe called
AssistantManagerClientService, that is not wrapped with HighlyAvailableService
and move some things from the current manager client service to it. Could also
explore making where the fate thrift client service could be called on any
manager. For this change would need to make client side changes similar to
what was done in #3262
Speaking of naming, I am going to rename HighlyAvailableService to
PrimaryManagerService or something like that. Its naming does not match its
purpose very well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
