membphis commented on a change in pull request #979: feature: support regex_uri option in proxy-rewrite plugin URL: https://github.com/apache/incubator-apisix/pull/979#discussion_r361111007
########## File path: t/plugin/proxy-rewrite.t ########## @@ -743,3 +743,198 @@ x-api-engine: APISIX x-real-ip: 127.0.0.1 --- no_error_log [error] + + + +=== TEST 26: set route(only using regex_uri) +--- config + location /t { + content_by_lua_block { + local t = require("lib.test_admin").test + local code, body = t('/apisix/admin/routes/1', + ngx.HTTP_PUT, + [[{ + "methods": ["GET"], + "plugins": { + "proxy-rewrite": { + "regex_uri": ["^/test/(.*)/(.*)/(.*)", "/$1_$2_$3"] + } + }, + "upstream": { + "nodes": { + "127.0.0.1:1980": 1 + }, + "type": "roundrobin" + }, + "uri": "/test/*" + }]] + ) + + if code >= 300 then + ngx.status = code + end + ngx.say(body) + } + } +--- request +GET /t +--- response_body +passed +--- no_error_log +[error] + + + +=== TEST 27: hit route(rewrite uri using regex_uri) +--- request +GET /test/plugin/proxy/rewrite HTTP/1.1 +--- response_body +uri: /plugin_proxy_rewrite +host: localhost +scheme: http +--- no_error_log +[error] + + + +=== TEST 28: hit route(404 not found) +--- request +GET /test/not/found HTTP/1.1 +--- error_code: 404 +--- no_error_log +[error] + + + +=== TEST 29: set route(Using both uri and regex_uri) +--- config + location /t { + content_by_lua_block { + local t = require("lib.test_admin").test + local code, body = t('/apisix/admin/routes/1', + ngx.HTTP_PUT, + [[{ + "methods": ["GET"], Review comment: ditto ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services